Re: [PATCH] ignore ,keep for efi earlyprintk

From: Ingo Molnar
Date: Thu Apr 24 2014 - 06:53:39 EST



* Dave Young <dyoung@xxxxxxxxxx> wrote:

> earlyprint=efi,keep results a kernel hang after "Freeing unused kernel memory"

That's a bug.

>
> Actually efi earlyprintk is using __init functions such as early_ioremap etc.
> Thus efi earlyconsole can not be kept.
>
> So just ignore it and give out a warning to user.

So, bugs should be fixed, not worked around.

earlyprintk=,keep is really useful for the occasional difficult low
level bug in the printk code or similar, because earlyprintk is a
completely separate code path from printk().

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/