Re: [PATCHv3 1/9] extcon: Add extcon_dev_allocate/free() to control the memory of extcon device

[Felipe Balbi]

Hi,

On Thu, Apr 24, 2014 at 11:58:29PM +0900, Chanwoo Choi wrote:
> >> +void extcon_dev_free(struct extcon_dev *edev)
> >> +{
> >> +     if (edev)
> >> +             kfree(edev);
> >
> > kfree(NULL) is safe
> 
> I don't understand about meaning 'kfree(NULL)'.
> Why do I free 'NULL' pointer' instead of 'edev' pointer?

you don't need to check if evdev is valid before calling kfree() on it
because if it happens to be NULL, no cute bunnies will be sacrificed.

-- 
balbi

Attachment: signature.asc
Description: Digital signature