Re: [PATCH 1/2] serial: sc16is7xx: depend on I2C

[Randy Dunlap]

On 04/25/14 13:39, Alexander Shiyan wrote:
> Fri, 25 Apr 2014 13:35:28 -0700 ÐÑ Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>:
>> On Sat, Apr 26, 2014 at 12:26:16AM +0400, Alexander Shiyan wrote:
>>> Fri, 25 Apr 2014 13:23:15 -0700 ÐÑ Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>:
>>>> On Fri, Apr 25, 2014 at 03:53:09PM -0400, jon@xxxxxxxxxx wrote:
>>>>> From: Jon Ringle <jringle@xxxxxxxxxxxxx>
>>>>>
>>>>> Signed-off-by: Jon Ringle <jringle@xxxxxxxxxxxxx>
>>>>> ---
>>>>>  drivers/tty/serial/Kconfig | 1 +
>>>>>  1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
>>>>> index c3e2b32..64c5659 100644
>>>>> --- a/drivers/tty/serial/Kconfig
>>>>> +++ b/drivers/tty/serial/Kconfig
>>>>> @@ -1180,6 +1180,7 @@ config SERIAL_SCCNXP_CONSOLE
>>>>>  
>>>>>  config SERIAL_SC16IS7XX
>>>>>  	tristate "SC16IS7xx serial support"
>>>>> +	depends on I2C
>>>>>  	select SERIAL_CORE
>>>>>  	select REGMAP_I2C if I2C
>>>>>  	help
>>>>> -- 
>>>>> 1.8.5.4
>>>>
>>>> Better, but I still have the build warnings :(
>>>
>>> I hope not same as before?
>>
>> Exactly the same.
> 
> Hmm...
> 
> In the source:
> #ifdef CONFIG_REGMAP_I2C
> Should be of course #ifdef CONFIG_I2C
> But this should not provide such warnings...

Can I see the warnings and .config file that causes them?


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/