Re: [tip:x86/efi] x86/efi: Save and restore FPU context around efi_calls (x86_64)

From: Matt Fleming
Date: Tue Apr 29 2014 - 06:46:33 EST


On Fri, 25 Apr, at 01:40:10PM, Borislav Petkov wrote:
>
> Well, the more I think about it, the more I'm persuaded that
> you actually do *really* need that WARN_ON_ONCE check there to
> make sure you're not fiddling with the FPU while in an interrupt
> context and in an unsafe way (see interrupted_kernel_fpu_idle() and
> interrupted_user_mode()). And so you do need the variants without the
> "__" which include the check.
>
> Anyway, here it is, do give it a good run:

Thanks Borislav, I gave this a run on my machines and everything appears
to be fine. I'll probably send it to tip by the end of the week, I'm
just gonna let it stew on my 'next' branch for a while.

--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/