Re: [PATCH tip/core/rcu 11/45] torture: Rename RCU_QEMU_INTERACTIVE to TORTURE_QEMU_INTERACTIVE

From: Paul E. McKenney
Date: Wed May 07 2014 - 19:58:05 EST


On Wed, May 07, 2014 at 02:27:08PM -0700, josh@xxxxxxxxxxxxxxxx wrote:
> On Mon, Apr 28, 2014 at 05:24:59PM -0700, Paul E. McKenney wrote:
> > - if test -n "$RCU_QEMU_INTERACTIVE" -a -n "$RCU_QEMU_MAC"
> > + if test -n "$TORTURE_QEMU_INTERACTIVE" -a -n "$RCU_QEMU_MAC"
> > then
> > echo -device spapr-vlan,netdev=net0,mac=$RCU_QEMU_MAC
> > echo -netdev bridge,br=br0,id=net0
> > - elif test -n "$RCU_QEMU_INTERACTIVE"
> > + elif test -n "$TORTURE_QEMU_INTERACTIVE"
> > then
> > echo -net nic -net user
>
> Not related to this patch, but: qemu defaults to -net nic -net user, so
> you don't need to specify it.

Good point, I wasn't aware of that. Paranoia will probably cause me
to leave it explicitly specified, though.

And yes, I freely admit that my paranoia is not evenly distributed. ;-)

Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/