Re: [PATCH] sched: Initialize rq->age_stamp on processor start

From: Corey Minyard
Date: Thu May 08 2014 - 14:47:35 EST


On 05/08/2014 11:13 AM, Peter Zijlstra wrote:
> On Tue, May 06, 2014 at 02:50:57PM -0500, minyard@xxxxxxx wrote:
>> From: Corey Minyard <cminyard@xxxxxxxxxx>
>>
>> If the sched_clock time starts at a large value, the kernel will spin
>> in sched_avg_update for a long time while rq->age_stamp catches up
>> with rq->clock.
>>
>> The comment in kernel/sched/clock.c says that there is no strict promise
>> that it starts at zero. So initialize rq->age_stamp when a cpu starts up
>> to avoid this.
>>
>> I was seeing long delays on a simulator that didn't start the clock at
>> zero. This might also be an issue on reboots on processors that don't
>> re-initialize the timer to zero on reset, and when using kexec.
>>
>> Signed-off-by: Corey Minyard <cminyard@xxxxxxxxxx>
> This patch made my cris-defconfig build fail.
Dang, I missed propagating a change. Yes, it's broken. One more time...

-corey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/