Re: [PATCH] i2c: qup: Fix pm_runtime_get_sync usage

From: Bjorn Andersson
Date: Fri May 09 2014 - 12:52:07 EST


On Fri, May 2, 2014 at 6:54 PM, Andy Gross <agross@xxxxxxxxxxxxxx> wrote:
[...]
> @@ -479,7 +479,7 @@ static int qup_i2c_xfer(struct i2c_adapter *adap,
> int ret, idx;
>
> ret = pm_runtime_get_sync(qup->dev);
> - if (ret)
> + if (ret < 0)
> goto out;

Sorry about that, thought I tested that path properly.
Wolfram, please pick this up as soon as possible as it renders the
driver useless if one enables pm runtime.

Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/