Re: [ 030/143] proc connector: fix info leaks

From: Willy Tarreau
Date: Mon May 12 2014 - 07:43:48 EST


On Mon, May 12, 2014 at 10:57:04AM +0200, Willy Tarreau wrote:
> > > diff --git a/drivers/connector/cn_proc.c b/drivers/connector/cn_proc.c
> > > index 6069790..3a2587a 100644
> > > --- a/drivers/connector/cn_proc.c
> > > +++ b/drivers/connector/cn_proc.c
> > > [...]
> > > module_init(cn_proc_init);
> > > + memset(&ev->event_data, 0, sizeof(ev->event_data));
> > > + msg->flags = 0; /* not used */
> >
> > That last hunk looks bogus. Probably the source of Christoph's compile error.
>
> Thank you guys, I'll check. I don't know why I didn't see them on an
> allmodconfig build.

I found why: CONFIG_PROC_EVENTS is not enabled when CONNECTOR=m.

Here's a fixed patch. Sorry for the trouble.

Willy