Re: [PATCH] drivers: staging: line6: Add blank lines after declarations

From: Greg KH
Date: Tue May 13 2014 - 08:02:08 EST


On Wed, May 14, 2014 at 02:56:42AM +0300, Artem Fetishev wrote:
> Use the more common kernel coding style.
>
> Signed-off-by: Artem Fetishev <wwctrsrx@xxxxxxxxx>
> ---
> drivers/staging/line6/capture.c | 4 ++++
> drivers/staging/line6/midi.c | 2 ++
> drivers/staging/line6/playback.c | 5 +++++
> drivers/staging/line6/pod.c | 5 +++++
> drivers/staging/line6/toneport.c | 2 ++
> drivers/staging/line6/variax.c | 2 ++
> 6 files changed, 20 insertions(+)
>
> diff --git a/drivers/staging/line6/capture.c b/drivers/staging/line6/capture.c
> index 0eda51d..14ed0d7 100644
> --- a/drivers/staging/line6/capture.c
> +++ b/drivers/staging/line6/capture.c
> @@ -97,6 +97,7 @@ void line6_unlink_audio_in_urbs(struct snd_line6_pcm *line6pcm)
> if (test_bit(i, &line6pcm->active_urb_in)) {
> if (!test_and_set_bit(i, &line6pcm->unlink_urb_in)) {
> struct urb *u = line6pcm->urb_audio_in[i];
> +
> usb_unlink_urb(u);
> }
> }
> @@ -122,6 +123,7 @@ void line6_wait_clear_audio_in_urbs(struct snd_line6_pcm *line6pcm)
> if (!alive)
> break;
> set_current_state(TASK_UNINTERRUPTIBLE);
> +
> schedule_timeout(1);
> } while (--timeout > 0);
> if (alive)

That line doesn't look like it needs to be added, why do so?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/