Re: [rfc]pwm: add xilinx pwm driver

From: Arnd Bergmann
Date: Thu May 15 2014 - 03:24:15 EST


On Wednesday 14 May 2014 13:26:13 Bart Tanghe wrote:
> @@ -0,0 +1,20 @@
> +Xilinx PWM controller
> +
> +Required properties:
> +- compatible: should be "xlnx,pwm-xlnx"
> +- add a clock source to the description
> +
> +Examples:
> +
> + axi_timer_0: timer@42800000 {
> + clock-frequency = <100000000>;
> + clocks = <&clkc 15>;
> + compatible = "xlnx,xlnx-pwm";
> + reg = <0x42800000 0x10000>;
> + xlnx,count-width = <0x20>;
> + xlnx,gen0-assert = <0x1>;
> + xlnx,gen1-assert = <0x1>;
> + xlnx,one-timer-only = <0x0>;
> + xlnx,trig0-assert = <0x1>;
> + xlnx,trig1-assert = <0x1>;
> + } ;
>

It seems you are missing a mandatory "#pwm-cells" property.
How is anybody supposed to use this?

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/