Re: [PATCH 08/20] perf tools: Allow hpp fields to be sort keys

From: Namhyung Kim
Date: Fri May 16 2014 - 02:30:35 EST


On Thu, 15 May 2014 14:51:32 +0200, Jiri Olsa wrote:
> On Mon, May 12, 2014 at 03:28:41PM +0900, Namhyung Kim wrote:
>
> SNIP
>
>> +static struct hpp_dimension hpp_sort_dimensions[] = {
>> + DIM(PERF_HPP__OVERHEAD, "overhead"),
>> + DIM(PERF_HPP__OVERHEAD_SYS, "overhead_sys"),
>> + DIM(PERF_HPP__OVERHEAD_US, "overhead_us"),
>> + DIM(PERF_HPP__OVERHEAD_GUEST_SYS, "overhead_guest_sys"),
>> + DIM(PERF_HPP__OVERHEAD_GUEST_US, "overhead_guest_us"),
>> + DIM(PERF_HPP__SAMPLES, "sample"),
>> + DIM(PERF_HPP__PERIOD, "period"),
>> +};
>
> just a nit.. overhead_guest_us|sys misplace are not properly aligned

Okay. Will fix.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/