Re: [tip:sched/core] sched: Rework sched_domain topology definition

From: Vincent Guittot
Date: Sun May 18 2014 - 04:04:35 EST


On 16 May 2014 11:57, James Hogan <james.hogan@xxxxxxxxxx> wrote:
> Hi Vincent,
>

[snip]

>
>
>> diff --git a/include/linux/sched.h b/include/linux/sched.h
>> index 2a4298f..656b035 100644
>> --- a/include/linux/sched.h
>> +++ b/include/linux/sched.h
>> @@ -985,6 +1006,38 @@ void free_sched_domains(cpumask_var_t doms[], unsigned int ndoms);
>>
>> bool cpus_share_cache(int this_cpu, int that_cpu);
>>
>> +typedef const struct cpumask *(*sched_domain_mask_f)(int cpu);
>> +typedef const int (*sched_domain_flags_f)(void);
>
> I just noticed, since May 9th, linux-next (ARCH=metag, gcc 4.2.4, with
> meta2_smp_defconfig) is showing loads of warnings due to the above
> line:
>
> include/linux/sched.h +1010 : warning: type qualifiers ignored on
> function return type
>
> Looks to me that the const serves no purpose in this context and could
> be removed.

Hi James,

Ok, i'm going to have a look a it. I haven't seen such warning during
my test but my configuration was different (ARCH=ARM gcc 4.7.1)

Thanks,
Vincent

>
> Cheers
> James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/