Re: [PATCH v2 05/06] staging: crypto: skein: rename macros

[Dan Carpenter]

On Mon, May 19, 2014 at 12:09:58PM +0400, Anton Saraev wrote:
> +/* ignore all asserts, for performance */
> +#define skein_assert_ret(x, ret_code)
> +#define skein_assert(x)

Not related to this patch, but defining away asserts like this is a bad
idea.  What if they have side affects like:

	skein_assert(foo++ == bar);

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/