Re: [PATCH 4/5] usb: gadget: net2280: Code Cleanup

[Alan Stern]

On Mon, 19 May 2014, Ricardo Ribalda Delgado wrote:

> Move logical continuations to end of line

This is almost totally unnecessary.  Some people prefer the 
operators at the end of the first line, other people prefer them at the 
start of the next line.  It's just a matter of taste and it doesn't 
matter.

> @@ -402,8 +402,8 @@ static void ep_reset_228x(struct net2280_regs __iomem *regs,
>  		BIT(DATA_PACKET_RECEIVED_INTERRUPT) |
>  		BIT(DATA_PACKET_TRANSMITTED_INTERRUPT) |
>  		BIT(DATA_OUT_PING_TOKEN_INTERRUPT) |
> -		BIT(DATA_IN_TOKEN_INTERRUPT)
> -		, &ep->regs->ep_stat);
> +		BIT(DATA_IN_TOKEN_INTERRUPT),
> +		&ep->regs->ep_stat);

This is an example of the one type of change that does make sense.  
Nobody should start lines with a ','.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/