Re: [PATCH] ACPI/hotplug: Fix STARTING/DYING action in acpi_cpu_soft_notify()

From: Toshi Kani
Date: Mon May 19 2014 - 19:05:52 EST


On Tue, 2014-05-20 at 00:55 +0200, Rafael J. Wysocki wrote:
> On Thursday, May 08, 2014 07:58:59 AM Toshi Kani wrote:
> > During CPU online/offline testing on a large system, one of the
> > processors got stuck after the message "bad: scheduling from the
> > idle thread!". The problem is that acpi_cpu_soft_notify() calls
> > acpi_bus_get_device() for all action types. CPU_STARTING and
> > CPU_DYING do not allow the notify handlers to sleep. However,
> > acpi_bus_get_device() can sleep in acpi_ut_acquire_mutex().
> >
> > Change acpi_cpu_soft_notify() to return immediately for CPU_STARTING
> > and CPU_DYING as they have no action in this handler.
> >
> > Signed-off-by: Toshi Kani <toshi.kani@xxxxxx>
>
> Queued up for 3.16, thanks!

Great! Thanks Rafael!
-Toshi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/