Re: [PATCH 1/3] perf: disable sampled events if no PMU interrupt

From: Peter Zijlstra
Date: Tue May 20 2014 - 09:27:37 EST


On Tue, May 20, 2014 at 09:19:27AM -0400, Vince Weaver wrote:
> On Tue, 20 May 2014, Peter Zijlstra wrote:
>
> > > +#define PERF_PMU_NO_INTERRUPT 1
> >
> > Are you ok with me making that:
> >
> > #define PERF_PMU_CAP_NO_INTERRUPT 0x01
>
> sounds good. All my recent fuzzing has made me paranoid enough to
> double check that yes indeed we don't need to slap an ULL on the end of
> that.

Thanks!

> Though I hope 32-bits is enough for this, I feel like we've just added the
> feature and suddenly all kinds of uses are coming out of the woodwork.

If we run out of bits we can always grow this thing, its not exposed to
userspace so no A[BP]I issues.

Attachment: pgpYCQqJ6yMm3.pgp
Description: PGP signature