Re: [PATCH v4 1/7] phy: add a driver for the Berlin SATA PHY

From: Antoine Ténart
Date: Tue May 20 2014 - 10:40:17 EST


On Tue, May 20, 2014 at 04:06:31PM +0200, Andrew Lunn wrote:
> > > > > +config PHY_BERLIN_SATA
> > > > > + bool
> > > >
> > > > Is there any real reason why this cannot be tristate?
> > >
> > > What we have seen with SATA drivers and phys, is there is link time
> > > breakage if the SATA driver is built in and the phy is modular.
> > >
> > > Maybe this has been fixed now?
> >
> > Using tristate shouldn't be a problem. I compiled without the PHY
> > driver, no link issue.
>
> The problem i think was when the PHY core and driver was a module and
> SATA built in. Please give that configuration a go.

I tested, it went fine.

This was actually fixed by:
b51fbf9fb0c3 phy-core: Don't allow building phy-core as a module

Antoine

--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/