Re: [PATCH v4 1/3] mfd: max8997: use regmap to access registers

From: Lee Jones
Date: Tue May 20 2014 - 12:19:58 EST


On Tue, 20 May 2014, Lee Jones wrote:

> > This patch modifies max8997 driver and each associated function driver,
> > to use regmap instead of operating directly on i2c bus. It will allow to
> > simplify IRQ handling using regmap-irq.
> >
> > Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> >
> > [For extcon part]
> > Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> >
> > [For leds part]
> > Acked-by: Bryan Wu <cooloney@xxxxxxxxx>
> > ---
> > drivers/extcon/extcon-max8997.c | 31 ++++----
> > drivers/input/misc/max8997_haptic.c | 34 +++++----
> > drivers/leds/leds-max8997.c | 13 ++--
> > drivers/mfd/Kconfig | 1 +
> > drivers/mfd/max8997-irq.c | 64 +++++++---------
> > drivers/mfd/max8997.c | 141 ++++++++++++++++-------------------
>
> Looks to be doing the right things and the diff looks good.
>
> For the MFD part:
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

I should add that I'd like this to go through the MFD tree.

I can supply the other maintainers with a pull-request as required.

> > drivers/power/max8997_charger.c | 33 +++++----
> > drivers/regulator/max8997.c | 87 +++++++++++-----------
> > drivers/rtc/rtc-max8997.c | 56 +++++++-------
> > include/linux/mfd/max8997-private.h | 17 ++---
> > 10 files changed, 228 insertions(+), 249 deletions(-)
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/