Re: [PATCH] x86/mce: Clear a useless global variable in mce.c

From: Tony Luck
Date: Tue May 20 2014 - 13:46:51 EST


On Tue, May 20, 2014 at 3:02 AM, Borislav Petkov <bp@xxxxxxxxx> wrote:
>> I'm OK with it going - but as I said before I'd like to see mce_callin
>> printed (so I can tell if just one cpu showed up, just the cpus from
>> one socket, or some other significant number).
>
> I don't think you want to do this unconditionally, do you? Rather maybe
> mce_timed_out dumps the order variable before the box panics :-)

Agreed - not unconditionally - just when we have a problem. Dumping
"order" in the timeout case would be a good place.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/