Re: [Patch v4 4/5] ARM: dts: keystone: update reset node to work with reset driver

From: Arnd Bergmann
Date: Wed May 21 2014 - 10:52:10 EST


On Wednesday 21 May 2014 17:27:33 Ivan Khoronzhuk wrote:
> The keystone driver requires the next additional properties:
>
> "ti,syscon-pll" - syscon register range used to access pll controller
> registers in order to use reset control registers.
> "ti,syscon-dev" - syscon register range used to access device state
> control registers in order to use mux block
> registers for all watchdogs.
>
> "ti,wdt_list" - option to declare what watchdog are used to reboot
> the SoC, so set "0" WDT as default.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@xxxxxx>

Same comment as what I had for the binding: it's not a register range
any more, but a phandle for a device.

> ---
> arch/arm/boot/dts/keystone.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/keystone.dtsi b/arch/arm/boot/dts/keystone.dtsi
> index 8b899ba..783da60 100644
> --- a/arch/arm/boot/dts/keystone.dtsi
> +++ b/arch/arm/boot/dts/keystone.dtsi
> @@ -78,7 +78,9 @@
>
> rstctrl: reset-controller {
> compatible = "ti,keystone-reset";
> - reg = <0x023100e8 4>; /* pll reset control reg */
> + ti,syscon-pll = <&pllctrl>;
> + ti,syscon-dev = <&devctrl>;
> + ti,wdt_list = <0>;
> };
>

I don't see a definition for the two labels, so this will cause a
build error. It makes sense to add them in the same patch.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/