Re: [PATCH] mm: /prom/pid/clear_refs: avoid split_huge_page()

From: Cyrill Gorcunov
Date: Wed May 21 2014 - 15:19:26 EST


On Wed, May 21, 2014 at 10:04:22PM +0300, Kirill A. Shutemov wrote:
> Currently we split all THP pages on any clear_refs request. It's not
> necessary. We can handle this on PMD level.
>
> One side effect is that soft dirty will potentially see more dirty
> memory, since we will mark whole THP page dirty at once.
>
> Sanity checked with CRIU test suite. More testing is required.
>
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> Cc: Andrea Arcangeli <aarcange@xxxxxxxxxx>
> Cc: Pavel Emelyanov <xemul@xxxxxxxxxxxxx>
> Cc: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
> Cc: Dave Hansen <dave.hansen@xxxxxxxxx>

Looks reasonable to me, thanks!

Reviewed-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/