Re: [PATCH 5/8] ARM: STi: DT: Add sdhci pin configuration for stih415

From: Lee Jones
Date: Thu May 22 2014 - 11:57:17 EST


> This patch adds the required pin config for the sdhci controller
> present in the stih415 SoC.
>
> Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@xxxxxx>

Switch these round - same with all the other patches.

> ---
> arch/arm/boot/dts/stih415-pinctrl.dtsi | 21 +++++++++++++++++++++
> arch/arm/boot/dts/stih415.dtsi | 12 ++++++++++++
> 2 files changed, 33 insertions(+)

[...]

> diff --git a/arch/arm/boot/dts/stih415.dtsi b/arch/arm/boot/dts/stih415.dtsi
> index d6f254f..6579b1d 100644
> --- a/arch/arm/boot/dts/stih415.dtsi
> +++ b/arch/arm/boot/dts/stih415.dtsi
> @@ -218,5 +218,17 @@
> resets = <&powerdown STIH415_KEYSCAN_POWERDOWN>,
> <&softreset STIH415_KEYSCAN_SOFTRESET>;
> };
> +
> + mmc0: sdhci@fe81e000 {
> + compatible = "st,sdhci";
> + status = "disabled";
> + reg = <0xfe81e000 0x1000>;
> + interrupts = <GIC_SPI 145 IRQ_TYPE_NONE>;
> + interrupt-names = "mmcirq";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_mmc0>;
> + clock-names = "mmc";
> + clocks = <&clk_s_a1_ls 1>;

Nit: These would be easier to read if the '='s were lined up (using tabs).

> + };
> };
> };

Apart from that:

Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/