Re: [PATCH] powerpc/perf/hv-24x7: use kmem_cache instead of aligned stack allocations

From: Cody P Schafer
Date: Thu May 22 2014 - 18:44:05 EST


On 05/22/2014 03:38 PM, Stephen Rothwell wrote:
Hi Cody,

On Thu, 22 May 2014 15:29:08 -0700 Cody P Schafer <cody@xxxxxxxxxxxxxxxxxx> wrote:

- *res = be64_to_cpu(result_buffer.result);
+ *res = be64_to_cpu(result_buffer->result);
+ kfree(result_buffer);
+ kfree(request_buffer);
+ return ret;

Why not just fall through here by removing the above 3 lines?

No reason except me not noticing it.

+
+out_hcall:
+ kfree(result_buffer);
+out_resb:
+ kfree(request_buffer);
+out_reqb:
return ret;
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/