Re: [PATCH 1/2] ASoC: max98090: Add master clock handling

From: Mark Brown
Date: Fri May 23 2014 - 07:41:41 EST


On Fri, May 23, 2014 at 05:06:27PM +0530, Tushar Behera wrote:
> On 23 May 2014 16:44, Mark Brown <broonie@xxxxxxxxxx> wrote:

> > Should be clk_prepare_enable() and similarly for the disable and you
> > should check the error codes but yes, that looks good.

> I was planning to keep clk_prepare/clk_unprepare in probe/remove.

Why - what purpose would it serve to leave the clock prepared but not
enabled?

Attachment: signature.asc
Description: Digital signature