Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines

From: Joe Perches
Date: Mon May 26 2014 - 01:05:57 EST


On Sun, 2014-05-25 at 21:58 -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations in many places to fix
> the following warning issued by checkpatch.pl:

Unrelated trivial note:

> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c

> @@ -2802,6 +2813,7 @@ int wdt_time_left(struct bpctl_dev *pbpctl_dev)
> static int wdt_timer(struct bpctl_dev *pbpctl_dev, int *time_left)
> {
> int ret = 0;
> +
> if (pbpctl_dev->bp_caps & WD_CTL_CAP) {
> {
> if (pbpctl_dev->wdt_status == WDT_STATUS_UNKNOWN)

unnecessary and ugly double brace


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/