Re: [PATCH 10/26] perf ui/browser: Add support to accumulated hist stat

From: Jiri Olsa
Date: Mon May 26 2014 - 13:53:03 EST


On Fri, May 23, 2014 at 07:04:07PM +0900, Namhyung Kim wrote:
> Print accumulated stat of a hist entry if requested.
>
> Tested-by: Arun Sharma <asharma@xxxxxx>
> Tested-by: Rodrigo Campos <rodrigo@xxxxxxxxxxx>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> ---
> tools/perf/ui/browsers/hists.c | 26 +++++++++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index 1c331b934ffc..1de7428a9771 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -632,7 +632,6 @@ static int __hpp__slsmg_color_printf(struct perf_hpp *hpp, const char *fmt, ...)
> ret = scnprintf(hpp->buf, hpp->size, fmt, percent);
> slsmg_printf("%s", hpp->buf);
>
> - advance_hpp(hpp, ret);
> return ret;

Whats the purpose of this one..? does not fit to what's in changelog

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/