Re: [PATCH] mm/process_vm_access: move into ipc/

From: Al Viro
Date: Mon May 26 2014 - 15:53:50 EST


On Mon, May 26, 2014 at 12:16:20PM -0700, Hugh Dickins wrote:
> On Sat, 24 May 2014, Konstantin Khlebnikov wrote:
>
> > "CROSS_MEMORY_ATTACH" and mm/process_vm_access.c seems misnamed and misplaced.
> > Actually it's a kind of IPC and it has no more relation to MM than sys_read().
> > This patch moves code into ipc/ and config option into init/Kconfig.
> >
> > Signed-off-by: Konstantin Khlebnikov <koct9i@xxxxxxxxx>
>
> I disagree, and SysV's ipc/ isn't where I would expect to find it.
> How about we just leave it where it is in mm?

Anything playing with get_user_pages(tsk, ...) with tsk != current is very
much a part of VM guts.

While we are at it, do_generic_file_read() *is* in mm/filemap.c. And signals
and pipes are also "a kind of IPC", so the rationale is really weak.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/