Re: [PATCH v4] gpio: Add support for Intel SoC PMIC (Crystal Cove)

From: Alexandre Courbot
Date: Tue May 27 2014 - 02:15:29 EST


On Tue, May 27, 2014 at 2:38 PM, Alexandre Courbot <gnurou@xxxxxxxxx> wrote:
>> + gpiochip_irqchip_add(&cg->chip, &crystalcove_irqchip, 0,
>> + handle_simple_irq, IRQ_TYPE_NONE);
>> +
>> + retval = request_threaded_irq(irq, NULL, crystalcove_gpio_irq_handler,
>> + IRQF_ONESHOT, KBUILD_MODNAME, cg);
>
> Can't you use devm_request_threaded_irq() here?

Ah, I suppose doing so would keep the IRQ handler active longer than
we want - please ignore this comment.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/