Re: [PATCH] block: flush queued bios when the process blocks

From: Jens Axboe
Date: Tue May 27 2014 - 13:42:33 EST


On 2014-05-27 10:26, Mikulas Patocka wrote:
On Tue, 27 May 2014, Jens Axboe wrote:

On 2014-05-27 09:23, Mikulas Patocka wrote:

The patch adds bio list flushing to the scheduler just besides plug
flushsing.

... which is exactly why I'm commenting. It'd be great to avoid yet one more
scheduler hook for this sort of thing.

--
Jens Axboe

One could create something like schedule notifier chain, but I'm not sure
if it is worth the complexity because of just two users. If more users
come in the future, it could be generalized.

Except such a thing already exists, there are unplug callback chains. All I'm asking is that you look into how feasible it would be to use something like that, instead of reinventing the wheel.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/