Re: [PATCH] block: mq flush: fix race between IPI handler and mq flush worker

[Jens Axboe]

On 2014-05-27 20:26, Jens Axboe wrote:
> On 2014-05-27 19:34, Ming Lei wrote:
> > On Wed, May 28, 2014 at 3:35 AM, Jens Axboe <axboe@xxxxxxxxx> wrote:
> > > On 05/27/2014 01:21 PM, Christoph Hellwig wrote:
> > > > On Tue, May 27, 2014 at 01:17:40PM -0600, Jens Axboe wrote:
> > > > > But I think you sent the old one again, not the new variant :-)
> > > >
> > > > Oh well, next try:
> > >
> > > This looks good to me. Was trying to think of ways to reduce that to one
> > > list iteration, but I think it's cleaner to just retain the two separate
> > > ones.
> > >
> > > Reusing REQ_SOFTBARRIER is fine as well, not used in blk-mq otherwise.
> > >
> > > Let me know when you have runtime verified it.
> >
> > Looks writing over ext4(especially sync writing) can survive
> > with Christoph's patch now, thanks Christoph.
> >
> > Reported-and-tested-by: Ming Lei <tom.leiming@xxxxxxxxx>
>
> Great! I'll queue it up here too, then.

Christoph, I'll just run a few tests and then queue it up in the 
morning. Can you send a properly signed-off patch with a commit message 
as well? I was writing one up, but I still need the signed-off-by.


--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/