Re: [PATCH v2 03/18] PCI: designware: Configuration space should be specified in 'reg'

From: Kumar Gala
Date: Thu May 29 2014 - 12:51:19 EST



On May 29, 2014, at 11:30 AM, Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Thu, May 29, 2014 at 11:03:36AM -0500, Kumar Gala wrote:
>
>> Just because the kernel doesn’t handle this is NO reason to change
>> the way the DT works.
>
> The OF specs do not specify how to process a config type ranges entry,
> and we all mutually agreed that the only sane interpretation for such
> a thing would be to describe an ECAM memory space so generic code
> could potentially make use of it.
>
> Since designware is not ECAM it should not use config ranges.
>
> This has come up multiple times now, and the above is the consensus.
>
> Jason

Well the designware controller does support ECAM, just that the current in kernel users don’t do cfg space that way.

So do we continue to support the current users that use a cfg range for a non-ECAM space? Or break their DT and convert them to using regs?

- k

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/