Re: [PATCH] block: virtio_blk: don't hold spin lock during world switch

[Jens Axboe]

On 2014-05-30 00:10, Rusty Russell wrote:
> Jens Axboe <axboe@xxxxxxxxx> writes:
> > If Rusty agrees, I'd like to add it for 3.16 with a stable marker.
>
> Really stable?  It improves performance, which is nice.  But every patch
> which goes into the kernel fixes a bug, improves clarity, improves
> performance or adds a feature.  I've now seen all four cases get CC'd
> into stable.
>
> Including some of mine explicitly not marked stable which get swept up
> by enthusiastic stable maintainers :(
>
> Is now there *any* patch short of a major rewrite which shouldn't get
> cc: stable?

I agree that there's sometimes an unfortunate trend there. I didn't 
check, but my assumption was that this is a regression after the blk-mq 
conversion, in which case I do think it belongs in stable.

But in any case, I think the patch is obviously correct and the wins are 
sufficiently large to warrant a stable inclusion even if it isn't a 
regression.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/