Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

From: Ralf Baechle
Date: Fri May 30 2014 - 11:49:44 EST


On Fri, May 30, 2014 at 01:39:15PM +0200, Geert Uytterhoeven wrote:

> > + if (test_bit(FLAG_REQUESTED, &chip->desc[id].flags))
> > + panic("gpio: removing gpiochip with gpios still requested\n");
>
> panic?
>
> Is this likely to happen?

And while we're at it - panic() is going to add a \n itself so don't pass a
string ending in \n to panic().

Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/