Re: [PATCH 1/2] regulators: Add definition of regulator_set_voltage_time() for !CONFIG_REGULATOR

From: Mark Brown
Date: Mon Jun 02 2014 - 06:02:24 EST


On Mon, Jun 02, 2014 at 03:24:05PM +0530, Viresh Kumar wrote:
> On 2 June 2014 15:21, Mark Brown <broonie@xxxxxxxxxx> wrote:

> > When you say they check for a valid regulator how are they doing that?
> > The stub will come into play if there isn't a dependency on REGULATOR.

> I meant they fail and quit if regulator_get() failed and so the first parameter
> to regulator_set_voltage() is guaranteed to be valid.

No, think about what you're changing here. You're changing the stub -
the stub has a regulator_get() which always succeeeds.

Attachment: signature.asc
Description: Digital signature