Re: [PATCH] staging: ft1000: ft1000-usb: ft1000_debug.c: Fix style errors and some warnings.

From: Dan Carpenter
Date: Mon Jun 02 2014 - 06:31:44 EST

On Sun, Jun 01, 2014 at 07:26:18PM -0700, Thomas Wood wrote:
> Don't use spaces as tabs, and fix other style errors and warnings.
> Signed-off-by: Thomas Wood <tommyandrena@xxxxxxxxx>

Too much in one patch. Break it up into one type of fix per patch and
send a series of patches.

[patch 1] use tabs
[patch 2] fix braces style
[patch 3] remove parens from return values
[patch 4] reverse an if statement

patch 3 and 4 are small enough that you could get away with pushing them
into a single "misc fixes" patch and we wouldn't have complained but the
first two patches are very big.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at