Re: [PATCH RFC 1/2] MAINTAINERS: Add "R:" designated-reviewers tag

From: Steven Rostedt
Date: Mon Jun 02 2014 - 13:29:14 EST


On Mon, 02 Jun 2014 10:22:58 -0700
Joe Perches <joe@xxxxxxxxxxx> wrote:

> > Paul Walmsley also noted the need for patch
> > submitters to know who the key reviewers are and suggested adding an
> > "R:" tag to the MAINTAINERS file to record this information on a
> > per-subsystem basis.
>
> I'm not sure of the value of this.
>
> Why not just mark the actual reviewers as maintainers?
>
> The lack of reviewers problem is entirely distinct from
> the proposed solution.
>
> I believe active reviewers will generally subscribe to a
> subsystem specific mailing list.
>
> Perhaps it'd be better to get a "linux-rcu@xxxxxxxxxxxxxxx"
> mailing list going.

I don't think we need a linux-rcu mailing list. I much rather see the
patches on LKML.

If you have a person that regularly reviews a patch and wants to be
Cc'd on all of them, then why not add them to MAINTAINERS?

>
> > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > @@ -73,6 +73,8 @@ Descriptions of section entries:
> > L: Mailing list that is relevant to this area
> > W: Web-page with status/info
> > Q: Patchwork web based patch tracking system site
> > + R: Designated reviewer, who should be CCed on patches,
> > + format: FullName <address@domain>
> > T: SCM tree type and location.
> > Type is one of: git, hg, quilt, stgit, topgit
> > S: Status, one of the following:
>
> If this is actually done, I suggest putting this
> "R" entry description immediately after the "M" entry.
>

Or perhaps after L:

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/