Re: sched: Disallow sched_attr::sched_policy < 0

From: Dave Jones
Date: Tue Jun 03 2014 - 09:16:53 EST


On Tue, Jun 03, 2014 at 10:47:18AM +0200, Richard Weinberger wrote:
> Am 03.06.2014 10:32, schrieb Peter Zijlstra:
> > On Tue, Jun 03, 2014 at 10:15:44AM +0200, Richard Weinberger wrote:
> >>> Once upon a time GCC also did warns like that, but my compiler is silent
> >>> :-(
>
> -Wtype-limits is what you're looking for.
>
> /me currently builds some kernel configs to find out how much noise it triggers...

Probably quite a bit I'd bet. There's a load of similar bugs in
coverity's db. Some of them look benign, and are probably there just in
case someone ever changes the type of a var, but it's non-obvious
sometimes if the values a function receives can ever actually be < 0

Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/