Re: [PATCH 11/13] perf tests: Allow reuse of test_file function

From: David Ahern
Date: Tue Jun 03 2014 - 09:51:45 EST

On 6/2/14, 3:18 PM, Jiri Olsa wrote:
Making the test_file function to be reusable for
new tests coming in following patches.

Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Cc: Corey Ashford <cjashfor@xxxxxxxxxxxxxxxxxx>
Cc: David Ahern <dsahern@xxxxxxxxx>
Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Cc: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Jean Pihet <jean.pihet@xxxxxxxxxx>
Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
tools/perf/tests/dso-data.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
index 3e6cb17..f5c8743 100644
--- a/tools/perf/tests/dso-data.c
+++ b/tools/perf/tests/dso-data.c
@@ -12,11 +12,15 @@

static char *test_file(int size)
- static char buf_templ[] = "/tmp/test-XXXXXX";
+#define TEMPL "/tmp/test-XXXXXX"

use /tmp/perf-test-XXXXXX or /tmp/perf-XXXXXX to we know where all these tmp files came from.

+ static char buf_templ[sizeof(TEMPL)];

why static? and ...

char *templ = buf_templ;
int fd, i;
unsigned char *buf;

+ strcpy(buf_templ, TEMPL);
+#undef TEMPL

why the need to change from char buf_templ[] to strcpy?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at