Re: [patch]blk-mq: blk_mq_tag_to_rq should handle flush request

From: Christoph Hellwig
Date: Wed Jun 04 2014 - 07:11:38 EST


On Fri, May 30, 2014 at 08:09:51AM -0600, Jens Axboe wrote:
> I have applied this one, but it irks me a little bit since we have
> to touch q->flush_rq->stuff from a potential hot path. I haven't
> thought much about this yet, but it would be a lot better if we
> could fold in the flush tag somehow.

This one also breaks scsi-mq by changing the first parameter of
blk_mq_tag_to_rq. With host-wide tags we won't have a hardware context
easily available when looking for a request by tag.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/