Re: [PATCH 1/3] lib: crc32: Greatly shrink CRC combining code

From: George Spelvin
Date: Wed Jun 04 2014 - 19:12:40 EST

>>> Perhaps a newline here.

>> Question: where do you think a newline should go? It's not obvious
>> to me. My style has been to keep as much of a declaration on one line
>> as possible so "git grep <function> include" is as informative as possible.

> It's just nit, but since you've asked, end result like this:
> --snip--
> u32 crc32_le_shift(u32 crc, size_t len) __attribute_const__;
> static inline u32 crc32_le_combine(u32 crc1, u32 crc2, size_t len2)
> {
> return crc32_le_shift(crc1, len2) ^ crc2;
> }
> --snap--

Ah, got it! I couldn't figure out where it would make sense to insert
a newline into the middle of one line, breaking it into two. Adding a
blank line makes sense, and makes your other comment make sense.

Good suggestion; I'll do it.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at