[PATCH 3.14 032/228] cfg80211: free sme on connection failures

From: Greg Kroah-Hartman
Date: Wed Jun 04 2014 - 19:20:57 EST

3.14-stable review patch. If anyone has any objections, please let me know.


From: Eliad Peller <eliad@xxxxxxxxxx>

commit c1fbb258846dfc425507a093922d2d001e54c3ea upstream.

cfg80211 is notified about connection failures by
__cfg80211_connect_result() call. However, this
function currently does not free cfg80211 sme.

This results in hanging connection attempts in some cases

e.g. when mac80211 authentication attempt is denied,
we have this function call:
ieee80211_rx_mgmt_auth() -> cfg80211_rx_mlme_mgmt() ->
cfg80211_process_auth() -> cfg80211_sme_rx_auth() ->

but cfg80211_sme_free() is never get called.

Fixes: ceca7b712 ("cfg80211: separate internal SME implementation")
Signed-off-by: Eliad Peller <eliadx.peller@xxxxxxxxx>
Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

net/wireless/sme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -235,7 +235,6 @@ void cfg80211_conn_work(struct work_stru
NULL, 0, NULL, 0,
false, NULL);
- cfg80211_sme_free(wdev);
@@ -649,6 +648,7 @@ void __cfg80211_connect_result(struct ne
cfg80211_put_bss(wdev->wiphy, bss);
+ cfg80211_sme_free(wdev);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/