[PATCH 3.14 012/228] kernfs: add back missing error check in kernfs_fop_mmap()

From: Greg Kroah-Hartman
Date: Wed Jun 04 2014 - 20:52:04 EST

3.14-stable review patch. If anyone has any objections, please let me know.


From: Tejun Heo <tj@xxxxxxxxxx>

commit b44b2140265ddfde03acbe809336111d31adb0d1 upstream.

While updating how mmap enabled kernfs files are handled by lockdep,
9b2db6e18945 ("sysfs: bail early from kernfs_file_mmap() to avoid
spurious lockdep warning") inadvertently dropped error return check
from kernfs_file_mmap(). The intention was just dropping "if
(ops->mmap)" check as the control won't reach the point if the mmap
callback isn't implemented, but I mistakenly removed the error return
check together with it.

This led to Xorg crash on i810 which was reported and bisected to the
commit and then to the specific change by Tobias.

Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
Reported-and-bisected-by: Tobias Powalowski <tobias.powalowski@xxxxxxxxxxxxxx>
Tested-by: Tobias Powalowski <tobias.powalowski@xxxxxxxxxxxxxx>
References: http://lkml.kernel.org/g/533D01BD.1010200@xxxxxxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

fs/kernfs/file.c | 2 ++
1 file changed, 2 insertions(+)

--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -476,6 +476,8 @@ static int kernfs_fop_mmap(struct file *

ops = kernfs_ops(of->kn);
rc = ops->mmap(of, vma);
+ if (rc)
+ goto out_put;

* PowerPC's pci_mmap of legacy_mem uses shmem_zero_setup()

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/