Re: linux-next crash in xhci_add_ep_to_interval

From: Valdis . Kletnieks
Date: Thu Jun 05 2014 - 17:11:41 EST

On Thu, 05 Jun 2014 12:05:56 -0700, Dan Williams said:

> Subject: usb: fix ->update_hub_device() vs hdev->maxchild
> From: Dan Williams <dan.j.williams@xxxxxxxxx>
> Commit d8521afe3586 "usb: assign default peer ports for root hubs"
> delayed marking a hub valid (set hdev->maxchild) until it had been fully
> configured and to enable the publishing of valid hubs to be serialized
> by usb_port_peer_mutex.
> However, xhci_update_hub_device() in some cases depends on
> hdev->maxchild already being set. Do the minimal fix and move it after
> the setting of hdev->maxchild.
> Cc: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> Reported-by: Valdis Kletnieks <Valdis.Kletnieks@xxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>

Applied cleanly, booted without complaint, the keyboard that's behind
the PS2-USB converter works.

uname -r reports 3.15.0-rc8-next-20140605-dirty as expected.

So feel free to stick a Tested-By: on there. :)

Attachment: pgpbD4FiSCQOJ.pgp
Description: PGP signature