Re: [PATCH 03/13] list: Add list_add_(before|after) macros
From: Christoph Hellwig
Date: Sat Jun 07 2014 - 09:38:56 EST
On Fri, Jun 06, 2014 at 12:51:35PM -0700, Hugh Dickins wrote:
> I'll express my opinion: perhaps it's widely shared, perhaps it is not.
> I think a patch like this (and the subsequent conversions) is unhelpful
> The Linux struct list_head is designed and intended to be used for both
> head and entry, and introducing aliases to make unnecessary distinctions
> just hinders development instead of helping it.
> If the reader is confused at first, I hope the reader will soon learn,
> without needing to rely on aliases such as these.
I fully concur with Hugh - the list_head is symmetric for heads vs
entires, and lots of code depends on that.
In addition to that multiple functions that do exactly the same thing
generall are a bad idea.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/