Re: [PATCH 6/7] cpufreq: intel_pstate: Trivial code cleanup

From: Joe Perches
Date: Tue Jun 10 2014 - 17:26:58 EST


On Tue, 2014-06-10 at 23:38 +0200, Rafael J. Wysocki wrote:

> > > is. And the result of (a * 100) / b may generally be different from
> > > a * 100 / b for integers (if the division is carried out first).
> >
> > I thought that (a * 100) / b is always equivalent to a * 100 / b.
>
> I'm not actually sure if that's guaranteed by C standards.

It is. left to right, same precedence.

> It surely
> wasn't some time ago (when there was no formal C standard).

c89 is 25 years ago now.

> Either way, in my opinion it's better to put the parens into the expression
> in this particular case to clearly state the intention.

I don't think so.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/