Re: [PATCH RFC 03/10] tools: Add le_direct/be_direct methods for unaligned access

From: Andy Lutomirski
Date: Tue Jun 10 2014 - 19:34:04 EST


On Tue, Jun 10, 2014 at 4:30 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> On 06/10/2014 04:25 PM, Andy Lutomirski wrote:
>> On Tue, Jun 10, 2014 at 4:13 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>>> For architectures which handle unaligned references transparently.
>>
>> Shouldn't these depend on host endianness?
>>
>
> See further down the series for how these end up being invoked.
>

Ah, sneaky.

Would it make sense to put a comment in this file (and similar files)
indicating that they must only be included on architectures of the
appropriate endianness?

--Andy

> -hpa
>
>



--
Andy Lutomirski
AMA Capital Management, LLC
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/