[RFC PATCH 4/5] kernel/rcu/tree.c:3435 fix a sparse warning

From: Pranith Kumar
Date: Wed Jun 11 2014 - 16:40:26 EST


kernel/rcu/tree.c:3435:21: warning: incorrect type in argument 1 (different modifiers)
kernel/rcu/tree.c:3435:21: expected int ( *threadfn )( ... )
kernel/rcu/tree.c:3435:21: got int ( static [toplevel] [noreturn] *<noident> )( ... )

by removing __noreturn attribute and adding unreachable() as suggested on the
mailing list: http://www.kernelhub.org/?p=2&msg=436683

Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
---
kernel/rcu/tree.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 9ab84d3..6029a2e 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1689,7 +1689,7 @@ static void rcu_gp_cleanup(struct rcu_state *rsp)
/*
* Body of kthread that handles grace periods.
*/
-static int __noreturn rcu_gp_kthread(void *arg)
+static int rcu_gp_kthread(void *arg)
{
int fqs_state;
int gf;
@@ -1777,6 +1777,9 @@ static int __noreturn rcu_gp_kthread(void *arg)
/* Handle grace-period end. */
rcu_gp_cleanup(rsp);
}
+
+ unreachable();
+ return 0;
}

/*
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/