Re: [PATCH 1/1] ata: Check and set 64-bit DMA mask for platform AHCI driver

[Suravee Suthikulpanit]

On 06/11/2014 04:30 AM, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> On Tuesday, June 10, 2014 04:54:01 PM David Milburn wrote:
> > On 05/23/2014 12:35 PM, suravee.suthikulpanit@xxxxxxx wrote:
> > > From: Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>
> > >
> > > The current platform AHCI drier does not set the dma_mask correctly
> > > for 64-bit DMA capable AHCI controller.  This patch checks the AHCI
> > > capability bit and set the dma_mask and coherent_dma_mask accordingly.
> > >
> > > Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>
> > > ---
> > >    drivers/ata/libahci_platform.c | 9 +++++++++
> > >    1 file changed, 9 insertions(+)
> > >
> > > diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> > > index 7cb3a85..85049ef 100644
> > > --- a/drivers/ata/libahci_platform.c
> > > +++ b/drivers/ata/libahci_platform.c
> > > @@ -368,6 +368,15 @@ int ahci_platform_init_host(struct platform_device *pdev,
> >
> > Hi Suravee,
> >
> > Would it be better to do the following before ahci_reset_controller()?
> >
> >           /* initialize adapter */
> >           rc = ahci_configure_dma_masks(pdev, hpriv->cap & HOST_CAP_64);
> >           if (rc)
> >                  	return rc;
>
> ahci_configure_dma_masks() is currently for PCI controllers only
> so it can't be used for libahci_platform.c.
>
> When it comes to setting DMA masks before ahci_reset_controller()
> I don't think that it matters but it will make platform code more
> similar to PCI one which is a good thing.

I can move this logic before ahci_reset_controller() in V2.

Suravee


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/