Re: [PATCH v2 2/5] acpi, apei, ghes: Introduce ACPI_APEI_NMI to make NMI error notification a GHES feature.

[Tomasz Nowicki]

On 12.06.2014 12:32, Robert Richter wrote:
> On 28.05.14 09:39:27, Tomasz Nowicki wrote:
> > +config ACPI_APEI_NMI
> > +	bool "NMI error notification support"
> > +	default y
> > +	depends on ACPI_APEI_GHES && X86
> > +	help
> > +	  Firmware first mode can use NMI notification mechanism to report errors
> > +	  to operating system. This feature is currently supported by X86
> > +	  architecture only.
> > +
>
> This selection is not necessary. I don't see why one should select
> this at all. It's either there for an arch or not. Just use ARCH_HAS_
> style and and hard select ARCH_HAS_ACPI_APEI_NMI for x86. There is no
> need for the ACPI_APEI_GHES dependency then.

It does make sense to me, will address your comment appropriately.

Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/