Re: [PATCH] of: avoid format string parsing in kobject names

From: Kees Cook
Date: Fri Jun 13 2014 - 13:30:40 EST


On Fri, Jun 13, 2014 at 7:55 AM, Rob Herring <robherring2@xxxxxxxxx> wrote:
> On Tue, Jun 10, 2014 at 11:57 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>> This makes sure a format string cannot leak into the kobject name that
>> is constructed. (And splits the >80 character line.)
>>
>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> Applied.
>
> This seems like a non-obvious thing to do, but I guess most people
> aren't dealing directly with kobjects.

Yeah, it's really unlikely this could get reached, but I just keep
cleaning this up any time I see them just to be safe. :)

Thanks!

-Kees


--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/